Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowed onClick prop in conjunction with href prop in EuiBadge #4035

Merged
merged 3 commits into from
Sep 15, 2020
Merged

Allowed onClick prop in conjunction with href prop in EuiBadge #4035

merged 3 commits into from
Sep 15, 2020

Conversation

TAYTS
Copy link
Contributor

@TAYTS TAYTS commented Sep 15, 2020 •
edited
Loading

Summary

Fixed #4031: Allowed onClick prop when href prop is provided in EuiBadge

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
    - [ ] Added documentation
  • Checked Code Sandbox works for the any docs examples
    - [ ] Added or updated jest tests
    - [ ] Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@elizabetdev
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4035/

chandlerprall
chandlerprall approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM; tested the Badge with onClick events example locally by adding hrefs. Tested keyboard accessibility as well.

@chandlerprall chandlerprall merged commit 816f835 into elastic:master Sep 15, 2020
@TAYTS TAYTS deleted the feature/allow-onclick-for-href-in-eui-badge branch September 16, 2020 12:44
@thompsongl thompsongl mentioned this pull request Sep 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onClick prop is excluded when href prop is provided in EuiBadge
4 participants
@TAYTS @kibanamachine @elizabetdev @chandlerprall